[Blind-sysadmins] Re: seeing dcode differnces and reviewing code

I generally work from the command line anyway, using git diff, and would recommend it. I find the GitHub table-based diffs harder to read. On 2/8/19 9:52 AM, Andrew Hodgson wrote:

Hi,

I am interested in the little more quicker to look at option as I think personally that anything else in relation to code may make us miss something especially if it is not obvious. Unfortunately if you view a diff in Github or Visual Studio, the changes are highlighted and can be easily seen, but even then it only works for a small subset of changes - anything large and people start complaining that they can't tell the differences easily.

I do a Git diff on a specific commit myself and find that works well, though it probably isn't quicker than a sighted person looking at the diff in a pull request. I find it especially irritating when people do comments in PRs, as it can be a right mare to try and find the correct line the comment is refering to, then reply to the comment in context.

Andrew.

________________________________________ From: Jason White via Blind-sysadmins [blind-sysadmins@lists.hodgsonfamily.org] Sent: 08 February 2019 13:07 To: Blind sysadmins list Cc: Chamandeep Singh Grover; Jason White Subject: [Blind-sysadmins] Re: seeing dcode differnces and reviewing code

If you're working with a document rather than lines of code in Git, you can always use word-diff, which shows the differences word by word rather than line by line. It can also take account of the syntax of the source file (e.g., TeX/LaTeX).

On 2/8/19, 04:54, "Chamandeep Singh Grover via Blind-sysadmins" wrote:

Hi, Thank you for your advice everyone. I tried the diff command and created the patch. This looks just like what I use to do with SVN, by using the show unified diff option. This solution works, but i'm looking for something else which may be a little more faster to look at.

Kind regards, Chamandeep singh Grover

On 1/21/19, Andrew Hodgson wrote: > Hi, > > Thanks for the details here - this is something I have struggled with a lot > recently especially given the comments section in pull requests on specific > lines of code. I usually end up messing something down the line because of > this. I used Github before and it was bearly ok, but VSTS really isn't > helpful in this regard at the moment. > > Andrew. > > -----Original Message----- > From: Jared Stofflett > Sent: 21 January 2019 20:25 > To: Blind sysadmins list > Subject: [Blind-sysadmins] Re: seeing dcode differnces and reviewing code > > I use Bitbucket at work as well. After a pull request is open from the > command-line I do the following git checkout develop git pull develop (these > two commands insure I have the latest stable code for comparison.) git > checkout pullrequestbranch git format-patch develop These last two commands > will grab the code associated with a pull request, and for each commit not > already in develop a patch file will be created with the differences between > develop and the commit that has not been merged into develop. > > On Mon, Jan 21, 2019 at 9:50 AM Jason White via Blind-sysadmins < > blind-sysadmins@lists.hodgsonfamily.org> wrote: > >> I usually just run "git diff" from the shell, specifying the desired >> revision or revisions, then review the output with my braille display. >> >> If it's a document rather than code, I use the --word-diff option. You >> can also specify the desired syntax for word-diff, which is helpful if >> you write LaTeX documents, as I do. >> >> -----Original Message----- >> From: Chamandeep Singh Grover via Blind-sysadmins >> >> Sent: Monday, January 21, 2019 8:16 AM >> To: Blind sysadmins list >> Cc: Chamandeep Singh Grover >> Subject: [Blind-sysadmins] seeing dcode differnces and reviewing code >> >> Hi All, >> >> We have recently migrated over to git and using bitbucket. I am using >> Jaws with Eclipse at the moment as my ide. >> I wanted to ask for peoples' advice on carrying out code reviews and >> seeing the differences between code versions. >> >> I am happy to try out a new ide such as visual studio code if it has >> worked well for some people, but it is quite difficult at the moment >> to understand the changes. >> Previously when using SVN, I had this linked up with code compare, >> which worked some what to alert changes. >> >> Any help/advice would be appreciated. >> >> Thank you >> Chamandeep Singh Grover >> _______________________________________________ >> Blind-sysadmins mailing list -- >> blind-sysadmins@lists.hodgsonfamily.org >> To unsubscribe send an email to >> blind-sysadmins-leave@lists.hodgsonfamily.org >> _______________________________________________ >> Blind-sysadmins mailing list -- >> blind-sysadmins@lists.hodgsonfamily.org >> To unsubscribe send an email to >> blind-sysadmins-leave@lists.hodgsonfamily.org >> > _______________________________________________ > Blind-sysadmins mailing list -- blind-sysadmins@lists.hodgsonfamily.org > To unsubscribe send an email to > blind-sysadmins-leave@lists.hodgsonfamily.org > _______________________________________________ > Blind-sysadmins mailing list -- blind-sysadmins@lists.hodgsonfamily.org > To unsubscribe send an email to > blind-sysadmins-leave@lists.hodgsonfamily.org > _______________________________________________ Blind-sysadmins mailing list -- blind-sysadmins@lists.hodgsonfamily.org To unsubscribe send an email to blind-sysadmins-leave@lists.hodgsonfamily.org

_______________________________________________ Blind-sysadmins mailing list -- blind-sysadmins@lists.hodgsonfamily.org To unsubscribe send an email to blind-sysadmins-leave@lists.hodgsonfamily.org _______________________________________________ Blind-sysadmins mailing list -- blind-sysadmins@lists.hodgsonfamily.org To unsubscribe send an email to blind-sysadmins-leave@lists.hodgsonfamily.org